Description

As a developer,, I need to make sure contributors can setup and run flutter on their local machine so they can start contributing to the project,

Mocks

N/A

Acceptance Criteria

• [ ] Update README.md with setup instructions

Definition of Done

• [ ] All of the required items are completed.
• [ ] Approval by 1 mentor.

Estimation

1 hour

Describe the bug As a user, When I attempt to login for the mentorship app it throws an internal server error and doesn't proceed further.

To Reproduce Steps to reproduce the behavior:

1. Go to login page
2. Click on login after entering test credentials
3. See error snackbar toast

Expected behavior Remove the error and proceed with login process to signin with the app. Screenshots

Smartphone: Android 9.0 Oppo 2020

Description

As a user of the system, I need to have links to terms and conditions on Register screen so that I can be aware of Terms of use, Code of Conduct and Privacy Policy.

On Registration Screen we need to have a proper text with the Terms and Conditions check box.

Text:

"By checking this box, I affirm that I have read and accept to be bound by the AnitaB.org Code of Conduct, Terms, and Privacy Policy. Further, I consent to the use of my information for the stated purpose."

Links to add:

Code of Conduct: https://ghc.anitab.org/code-of-conduct/ Terms of use: https://anitab.org/terms-of-use/ Privacy Policy: https://anitab.org/privacy-policy/

Screenshots of the issue

Android version:

Flutter current version:

Acceptance Criteria

Update [Required]

• [ ] Add links to Terms and Conditions, Code of Conduct and Privacy Policy on Sign Up screen

Definition of Done

• [ ] All of the required items are completed.
• [x] Approval by 1 mentor.

Estimation

🤷‍♀️

Description

Add Pagination to load the members list on members page

Fixes #85

Flutter Channel:

• [x] I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

• Code

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Physical Device. Steps : Go to members page and scroll down too see if pagination works as required.

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

• [x] My changes generate no new warnings

Description

As a user, I need a cancel button on change password alert box which can take me back if I prefer not to change my password.

Screenshots of the issue

Acceptance Criteria

• [ ] Include a cancel button left to submit button

Definition of Done

• [ ] All of the required items are completed.
• [x] Approval by 1 mentor.

Estimation

1 hour

Description

Add confirm password field with validation and toggle password visibility button on the change password popUp

Fixes #76

Flutter Channel:

• [ ] I have used the Flutter Beta channel on my local machine

Type of Change:

• Code

Code/Quality Assurance Only

• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical Device Steps:

• Go to the Settings page by clicking on the icon at the top right corner of the homepage.
• Click on the Change Password button to see whether the feature works properly or not

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

• [x] My changes generate no new warnings
• [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• [ ] Any dependent changes have been published in downstream modules

Is your feature request related to a problem? Currently the searching functionality in the MembersPage doesn't work.

Describe the solution you'd like Adding the search feature like in the Android app.

A final solution should preferably use BLoC pattern (like the rest of the app). I'm not quite sure how it would look like, so the person who will be doing it: implement it so that it will just work and we will iterate on it & improve.

Is your feature request related to a problem? Please describe. The tasks section is not organized to show completed tasks and yet to complete tasks.

Describe the solution you'd like There should be two sections/drop sections to show to-do tasks and completed tasks separately. Just like in Android version of Mentorship.

Additional context Android version:

Flutter version:

Is your feature request related to a problem? Please describe. Currently changing available to mentor and needs mentoring on the RelationPage doesn't have any effect.

Describe the solution you'd like I'd like this to work. I'd love this to work and be nicely coded :)

Additional context I remember I had some issues with this while speed-coding this app during GCI and finally forgot to finish this :) That's why it isn't already implemented.

Recently a PR was merged which was supposed to ease out testing apks, without Android Studio, but most people are unaware about this. We need to create a doc which tells more about this feature. More info here

Description

Add loading indicator on screen to help user understand what's happening. If a user has a slow internet connection, the changing password request can take long and without a loading indicator he/she might think the apps stuck. Loading indicators will tell that the process is currently going on
Fixes #67 Fixes #94

Flutter Channel:

• [x] I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

• User Interface

Code/Quality Assurance Only

• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical device. Check gif below

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

• [x] My changes generate no new warnings

Is your feature request related to a problem? Please describe. Currently we use Github actions to build on every PR and create a artifact where the testing team can download it to test the changes. We also use travis CI for building a apk and pushing it to the apk branch after every push to the develop branch.

Describe the solution you'd like We should remove travis ci as we have exceded the quota and migrate that pipeline to github actions

Describe the bug The confirm password function of the register page doesn't seem to work. Even if the password and confirm password don't match, the confirmation email is sent.

To Reproduce Steps to reproduce the behavior:

1. Go to the signup page
2. Fill the detail. Enter different passwords in the password and confirm password fields.
3. Click signup
4. The confirmation email is sent

Expected behavior If the password and confirm password don't match it should show a warning to the user.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Device: samsung m21
• OS: Android

Additional context Maybe its just me. Please check.

Description

Added regex email validation. Fixes #149

Flutter Channel:

• [X] I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

• Code

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The following cases are tested *Following are invalid cases

• Missing @ sign and domain
• Missing username
• Two @ sign
• Leading or trailing dot in address
• And other invalid emails

invalid email

valid email

Checklist:

Delete irrelevant options.

• [X] My PR follows the style guidelines of this project
• [X] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• [X] My changes generate no new warnings

Description

Added Google Sign In to the app. Was not able to implement Apple Sign In as it requires setting up a paid apple developers account. This change depends on PR 719 of mentorship-backend which is not merged yet.Therefore, merged PR 719's code with the forked mentorship-backend repo and used it as backend.

For setting up google sign in for android: 1.) Create a google console project. 2.) Create OAuth client id for web app(Use this client id in backend) and android(by putting in correct application id and sha1 code). 3.) Under res/values/strings.xml put

 <?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="default_web_client_id">{Web app Client id goes here}</string>
</resources>

(As you need a backend client id for extracting idToken after google sign in, refer documentation) . 4.) Make sure you use the same web app client id in backend.

For iOS: I have not tested the code in iOS as a mac is not available to me.

Fixes #137 (Not completely)

Flutter Channel:

• [x] I have used the Flutter Beta channel on my local machine

Type of Change:

• Code

Code/Quality Assurance Only

• This change requires a documentation update (software upgrade on readme file)
• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Sign In:

Logout:

Google Sign In works as it should but breaks change password feature.

Checklist:

Delete irrelevant options.

• [X] My PR follows the style guidelines of this project
• [X] I have performed a self-review of my own code or materials
• [ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] Any dependent changes have been merged

Code/Quality Assurance Only

• [X] My changes generate no new warnings
• [X] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• [ ] Any dependent changes have been published in downstream modules

Is your feature request related to a problem? Please describe. Currently during Registration, Email and Password are checked only to ensure they are non empty values. Proper validation must be done to ensure they are valid values.

Describe the solution you'd like Regex Based Validation

Describe alternatives you've considered N/A

Additional context

Description

Github deprecated some of its commands, specifically the setenv and addPath. This PR updates the deps to fix this

How Has This Been Tested?

Tested here

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• [x] My changes generate no new warnings