Versions Flutter: 1.19.0-2.0.pre.83 Android 8 photo_view: ^0.9.2

Describe the bug

I used PhotoViewGallery.builder to show a set of images. But when I use finger to swipe or click, it is hard to invoke the action. Only by my little finger, will it be invoked sometimes.

For example, onTapDown, onTapUp or double click to zoom. When I debug in emulator by mouse and use mouse in my Android mobile phone, it works normally. But it is too hard by finger.

But if I use PhotoViewGestureDetector directly, everything works normally.

To Reproduce

Here is my code:

Container(
  decoration: BoxDecoration(color: Colors.black),
  constraints: BoxConstraints.expand(
    height: MediaQuery.of(context).size.height,
  ),
  child: Stack(
    children: [
      Positioned.fill(
        child: PhotoViewGallery.builder(
          scrollPhysics: const BouncingScrollPhysics(),
          backgroundDecoration: BoxDecoration(color: Colors.black),
          loadingBuilder: (c, ImageChunkEvent e) => ImageLoadingView(title: '${_currentPage + 1}', event: e),
          loadFailedChild: ImageLoadFailedView(title: '${_currentPage + 1}'),
          onPageChanged: _onPageChanged,
          pageController: _controller,
          itemCount: widget.images.length,
          builder: (BuildContext context, int index) => PhotoViewGalleryPageOptions(
            initialScale: PhotoViewComputedScale.contained,
            minScale: PhotoViewComputedScale.contained / 2,
            maxScale: PhotoViewComputedScale.covered * 2,
            filterQuality: FilterQuality.high,
            onTapDown: (c, d, v) => _onPointerDown(d.globalPosition),
            onTapUp: _onImagePointerUp,
            heroAttributes: PhotoViewHeroAttributes(
              tag: '${widget.images[index]}: $index',
            ),
            imageProvider: LocalOrNetworkImageProvider(
              url: widget.images[index],
              file: () async => _presenter.getFile(index: index),
            ),
          ),
        ),
      ),
      Positioned(
        bottom: 0,
        child: Listener(...),
      ),
    ),
  ),
)


double _pointerDownXPosition = 0;
double _pointerDownYPosition = 0;

void _onPointerDown(Offset pos) {
  _pointerDownXPosition = pos?.dx ?? 0;
  _pointerDownYPosition = pos?.dy ?? 0;
}

void _onImagePointerUp(BuildContext c, TapUpDetails d, PhotoViewControllerValue v) {
  var width = MediaQuery.of(context).size.width;
  var height = MediaQuery.of(context).size.height;
  Fluttertoast.showToast(
    msg: 'localPosition: ${d.localPosition}, globalPosition: ${d.globalPosition}, ' +
        'x: ${d.globalPosition?.dx}, y: ${d.globalPosition?.dy}, width: $width, height: $height',
  );
}

Screenshots

Emulator:

Android by mouse:

Android by finger: (I can't capture it)

With the new stable version 2.10.0 of Flutter, there is a new problem. When building this widget with some images, it works fine. But when leaving/disposing this widget, there is crash report in the console that says Looking up a deactivated widget's ancestor is unsafe. The solution for this problem was to initialize the controller inside initState to ensure, that everything was initialized correctly in the lifecycle of a stateful widget. When the widget is disposed, there is no problem disposing these controllers.

When I open Photoview and dont do anything bot pops the screen I get an error:

FlutterError (Looking up a deactivated widget's ancestor is unsafe. At this point the state of the widget's element tree is no longer stable. To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by calling dependOnInheritedWidgetOfExactType() in the widget's didChangeDependencies() method.)

If I triggers some events, e.g. panning, scaling ,it goes well.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.869, on macOS 11.4 20F71 darwin-x64, locale sv-SE) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2) [✓] Xcode - develop for iOS and macOS (Xcode 13.1) [✓] Chrome - develop for the web [✓] Android Studio (version 2020.3) [✓] VS Code (version 1.62.3)

A known behaviour?

Is your feature request related to a problem? Please describe. It is quite troublesome to implement a popup photo view with zoom, drag and also drag to dismiss (change in transparency), since this library already provided the foundation of zoomable image, it is great that the library able to extend to a popup version.

Describe the solution you'd like A popup photo view which able to zoom, drag and also drag to dismiss (change in transparency) similar to Facebook.

Error "Looking up a deactivated widget's ancestor is unsafe." fixed by https://github.com/bluefireteam/photo_view/pull/499, but I'm still waiting for new release.

I don't know if I use the controller correctly. but it still didn't work when i have tried many times? could you please pointed out where my fault is？

final item = widget.galleryItems[index];
    return PhotoViewGalleryPageOptions.customChild(
      scaleStateController: scaleStateController,
      child: GestureDetector(
        behavior: HitTestBehavior.translucent,
        onTap: () {
          Navigator.of(context).pop();
        },
        onDoubleTap: () {
          scaleStateController.scaleState = PhotoViewScaleState.zoomedOut;
        },
        child: CustomImage(
          imageSize: ImageSize.original,
          width: MediaQuery.of(context).size.width,
          imageUrl: item,
        )
      ),
      initialScale: 0.5,
      minScale: PhotoViewComputedScale.contained * 1,
      maxScale: PhotoViewComputedScale.covered * 2,
    );
  }

what i want to deal is to zoom the pic by doubleTap

PhotoViewGallery does not scroll sometime and the onTapUp callback dose not run.

What is the current behavior? When i am scrolling the gallery horizontal to switch the image , the gallery does not response. I set onTapUp callback to the options, but the tapup callback does not run.

Versions: photo_view 0.9.0 OS:Android ,have not test ios yet Flutter:Flutter 1.9.1+hotfix.6

I am using flutter_advanced_networkimage as the imageprovider , is it related?

Error: The argument type 'PointerEvent' can't be assigned to the parameter type 'PointerDownEvent'.

Error generated on build progress... Its necessary to change void addAllowedPointer(PointerEvent event) to void addAllowedPointer(PointerDownEvent event) according https://flutter.dev/docs/release/breaking-changes/gesture-recognizer-add-allowed-pointer

Cannot browse gallery images. Images do not respond to slides and taps, only to resize. This is on Android only. iPhone works as expected. This started after Flutter 1.2 upgrade.

I'm wanting to allow the user to tap a button to rotate the photo view custom child by 90 degrees left or right by tapping a button, but they should not be able to rotate the image manually.

I found that I could not achieve this at all unless the photo view's enableRotation parameter is enabled. I had expected this to only relate to user actions.

Secondly, it isn't clear how PhotoViewController's rotation value should be updated to perform the rotation. My initial thought was to add either 90 or 0.25 to the rotation value, but this resulted in a child that was not at right angles to the initial orientation. I was surprised to find that adding a value of 1.57 seemed to do what I wanted – but still wrong after many rotations.

It would be useful to have an example that should how to rotate programmatically by a number of degrees.

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Stack(
          children: <Widget>[
            PhotoView.customChild(
              enableRotation: true,
              controller: _photoViewController,
              backgroundDecoration: BoxDecoration(
                color: Brand.of(context).secondaryColor,
              ),
              child: Icon(Icons.home, size: 144) ?? FloorplanImage(),
              initialScale: PhotoViewComputedScale.contained,
              minScale: PhotoViewComputedScale.covered * 0.5,
              maxScale: PhotoViewComputedScale.covered * 2.0,
            ),
            Positioned(
              top: 30,
              right: 30,
              child: FloatingActionButton(
                child: Icon(Icons.rotate_right),
                onPressed: () => _photoViewController.rotation = _photoViewController.rotation + 1.5705,
              ),
            ),
          ],
        ),
      ),
    );
  }

List<Map> imageList = [
  {
    'provider': const NetworkImage(
        "https://img.zcool.cn/community/012c1559b2441ea801211d258355d3.jpg@1280w_1l_2o_100sh.jpg"),
    'tag': 'tag1',
    'fillScale': PhotoViewComputedScale.covered
  },
  {
    'provider': const NetworkImage(
        "http://img.pptjia.com/image/20180117/767f4b74a8d7b453b149430ee364c9ce.jpg"),
    'tag': 'tag2',
    'fillScale': PhotoViewComputedScale.contained
  },
  {
    'provider': const NetworkImage(
        "http://www.hiphotos.baidu.com/image/pic/item/8644ebf81a4c510f3666841a6b59252dd42aa514.jpg"),
    'tag': 'tag3',
    'fillScale': PhotoViewComputedScale.contained
  },
  {
    'provider':
        const NetworkImage("http://www.17qq.com/img_qqtouxiang/30526384.jpeg"),
    'tag': 'tag4',
    'fillScale': PhotoViewComputedScale.contained
  }
];

List<PhotoViewGalleryPageOptions> _takePageOptions(
      List<Map> imageProviderList) {
    return imageProviderList.map(
      (map) {
        return PhotoViewGalleryPageOptions(
          imageProvider: map['provider'],
          minScale: map['fillScale'],
          maxScale: PhotoViewComputedScale.covered * 1.1,
          initialScale: map['fillScale'],
          heroTag: map['tag'],
        );
      },
    ).toList();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Container(
          constraints: BoxConstraints.expand(
            height: MediaQuery.of(context).size.height,
          ),
          child: Stack(
            alignment: Alignment.bottomRight,
            children: <Widget>[
              PhotoViewGallery(
                pageOptions: _takePageOptions(widget.imageList),
                // pageOptions: <PhotoViewGalleryPageOptions>[
                //   PhotoViewGalleryPageOptions(
                //     imageProvider: widget.imageProvider,
                //     heroTag: "tag1",
                //   ),
                //   PhotoViewGalleryPageOptions(
                //       imageProvider: widget.imageProvider2,
                //       heroTag: "tag2",
                //       maxScale: PhotoViewComputedScale.contained * 0.3),
                //   PhotoViewGalleryPageOptions(
                //     imageProvider: widget.imageProvider3,
                //     minScale: PhotoViewComputedScale.contained * 0.8,
                //     maxScale: PhotoViewComputedScale.covered * 1.1,
                //     heroTag: "tag3",
                //   ),
                // ],
                loadingChild: widget.loadingChild,
                backgroundDecoration: widget.backgroundDecoration,
                pageController: widget.pageController,
                onPageChanged: onPageChanged,
              ),
              Container(
                padding: const EdgeInsets.all(20.0),
                child: Text(
                  "Image ${currentIndex + 1}",
                  style: const TextStyle(
                      color: Colors.white, fontSize: 17.0, decoration: null),
                ),
              )
            ],
          )),
    );
  }

Hi,

I read the doc and I don't manage to find a way to move to the next ou previous image from a keyboard key on a desktop application. Did I miss something ? Is there any current way to do it ?

Thanks.

🐛 Bug Report

When users pinch zoom to the maximum, it starts lagging until the app crashes.

Expected behavior

The hero animation when pinching the maximum zoom value should not crash the app.

Reproduction steps

Just place a PhotoView showing an image (in my case it's a 500x500 PNG file) with disableGestures = false and zoom it to the maximum using your fingers.

Version: 0.14.0

Platform: Android 13, iOS 15

Describe the bug Currently, PhotoViewController.scale is nullable. However, this value should not be null according to @renancaraujo.

Although, I do not envision how this value can be nullable. If so, docs should be added to document under what scenarios this values is nullable.

To Reproduce (https://github.com/bluefireteam/photo_view/blob/7e8c335ad718c71e22402a920c939d949106d508/lib/src/controller/photo_view_controller.dart#L56)

What is the current behavior? PhotoViewController.scale is double? == true PhotoViewController.scale is double == false

Expected behavior PhotoViewController.scale is double == true

Screenshots N/a

Which versions of Flutter/Photo View, and which browser / OS are affected by this issue? Did this work in previous versions of Photo View?

Photo View ^0.14.0

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.2.1 21D62 darwin-arm, locale
    en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

Describe the bug: Take a portrait photo. Lets name top-left most point A. Rotate photo 90-degrees anti-clockwise (make it lanscape), zoom-in, now try to look at zoomed point A. We won't be able to scroll the photo to the point to see it. PS: The same will happen for a bottom-left point in a landscape-photo.

To Reproduce: Attached a GIF. Any portrait photo will do.

Version: 0.14.0. This has always been the case.

My guess is that it is happening because the proportion of photo remains same, even when it is rotated. So, when pulling-area of the zoomed+rotated photo in one direction ends earlier than expected.