In the newest update of Flutter 1.17 / Dart 2.8 it looks there's an issue with persist_theme. When the user changes to dark mode or off dark mode, the theme is not persisted when pop() is called.

For example:

MainScreen() => push to Settings() (change theme)

When you pop back to MainScreen it will show the original theme. Any ideas? It was working fine before the Flutter 1.17 update.

I've attached a quick gif.

New version of flutter requies different formating of ListenableProvider:

Citation from listenable_provider.dart:

The default constructor of ListenableProvider/ChangeNotifierProvider must create a new, unused Listenable.

If you want to reuse an existing Listenable, use the second constructor:

• DO use ChangeNotifierProvider.value to provider an existing ChangeNotifier:

MyChangeNotifier variable; ChangeNotifierProvider.value( value: variable, child: ... )

• DON'T reuse an existing ChangeNotifier using the default constructor.

MyChangeNotifier variable; ChangeNotifierProvider( create: (_) => variable, child: ... )

As far as I can thell, ThemeModel.accentColor should only be used in the ThemeModel.theme getter for the custom theme. Using it directly leads to bugs. ThemeModel.accentColor should probably be private.

Please remove _prefs.clear in reset method to avoid clearing all data for Shared Preferences if used in App elsewhere. Better clear only used values. A prefix for the names would also be nice to avoid name clashes

Changes I made: Example:

• removed _setTargetPlatformForDesktop, as it is no longer required.
• use Theme.of(context) instead of Provider.of<ThemeModel>(context), because that returns the actual ThemeData object, is probably already familiar to users, and does not require knowledge (and an import) of provider.

Readme:

• Updated the example in the readme with the actual example, because that's where users will probably copy-paste from.
• Removed a reference to scoped_model, and added a short info about provider.
• Fixed the screenshots.

Sorry for not splitting this into smaller pieces :)

According to the provider documentation:

If you already have an object instance and want to expose it, you should use the .value constructor of a provider.

Failing to do so may call the dispose method of your object when it is still in use.

DO use ChangeNotifierProvider.value to provide an existing ChangeNotifier.

MyChangeNotifier variable;

ChangeNotifierProvider.value(
  value: variable,
  child: ...
)

DON'T reuse an existing ChangeNotifier using the default constructor

MyChangeNotifier variable;

ChangeNotifierProvider(
  create: (_) => variable,
  child: ...
)

This is actually a regression from the flutter_material_color_picker package v1.0.4 (https://github.com/Pyozer/flutter_material_color_picker/commit/e6e638b7cef89d6c2fe62adaa49028cc5d898a14). To be able to display the color picker in a dialog inside a SingleChildScrollView, shrinkWrap must be true.

With the use of SwitchListTile the entire ListTile is interactive, and tapping anywhere on the Tile will trigger the switch. Note that I've renamed the leading parameter to secondary to be consistent with SwitchListTile, making this a breaking change. Maybe we should just keep leading? secondary is always placed in the ListTile.leading spot anyways, so it would probably not confuse users.