Presumably this change is a bit controversial, I'm merely suggesting a name change, not really sure the one that I picked is really good or not.

Naming this homescreen doesn't really make sense in platforms where there are multiple instances of the embedder running so I suggested (re)naming it flutter-ed (flutter-embedder).

Obviously the meta-flutter recipes also need changing, but I said to get the ball rolling and see how people feel about this.

I can build desktop ubuntu 20 just fine but when it comes to running Copy libflutter_engine.so to /usr/local/lib or use LD_LIBRARY_PATH to point downloaded engine for build:

Question where do i get libflutter_engine.so from ? Do I try and build a copy using https://github.com/meta-flutter/flutter_embedded
or Can i use one of my local copies created during flutter snap install maybe the release copy

parallels > find /home/parallels/snap/flutter -type f -name "libflutter*.so" -print /home/parallels/snap/flutter/common/flutter/bin/cache/artifacts/engine/android-x86/libflutter.so /home/parallels/snap/flutter/common/flutter/bin/cache/artifacts/engine/android-x64/libflutter.so /home/parallels/snap/flutter/common/flutter/bin/cache/artifacts/engine/linux-x64/libflutter_linux_gtk.so /home/parallels/snap/flutter/common/flutter/bin/cache/artifacts/engine/linux-x64-release/libflutter_linux_gtk.so /home/parallels/snap/flutter/common/flutter/bin/cache/artifacts/engine/linux-x64-profile/libflutter_linux_gtk.so

please advise regards

This patch series includes the ability start up correctly as maximized/fullscreen from the beginning on the AGL platform.

Specifically this patch series:

• groups together agl-shell protocol requests in the EglWindow constructor
• makes part of the initial commit the set_toplevel request and the frame callback
• redoes the EGL window/surface creation to allow starting up as maximized/fullscreen
• paves the way to have regular applications starting up in various scenarios (compositor sending 0 values and apps need to chose a default value).

With these changes I get the gallery application running on both swrast (llvmpipe) and HW accelerated drivers.

LE: I've verified/tested this patch series on x86_64:

• Debian testing with gnome-shell/mutter 4.20
• Debian testing with weston main (post weston 10)
• Debian testing with AGL compositor master
• AGL platform (qemu x86_64) w/ a master from a few days ago (6 of May 2022). Together with https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27460 (an unrelated change to this patch series) we get a boot-up to flutter gallery application.

xdg_shell -replaces wl_shell for xdg_shell

Multiple outputs -Adds support for saving state on multiple outputs -Enables deriving the buffer scaling factor

Cleanup -Remove unused methods/variables -Remove unused headers -Initialize uninitialize variables -rename m_engine to m_flutter_engine in App class

Remove sprawl option -Not required with xdg_shell

Update README.md -Enabling flutter desktop causes App build issue. This has been the case for some time. Only use custom devices for debugging eLinux Flutter.

FPS feature cleanup -Fix narrowing warnings -Update README for usage

Remove pinch gesture references -Dart layer gesture detection being used. Not all targets have this protocol

Firs of all this is not an issue. I am not able to find steps to run release version of flutter apps.

With this patch I was able to run debug version of the the apps with ivi-homescreen.

diff --git a/shell/engine.cc b/shell/engine.cc
index 5eb4205..7c979f1 100644
--- a/shell/engine.cc
+++ b/shell/engine.cc
@@ -87,7 +87,7 @@ Engine::Engine(App* app, size_t index)
       }),
       m_renderer_config(
           {.type = kOpenGL,
-           .open_gl = {
+           .open_gl = FlutterOpenGLRendererConfig {
                .struct_size = sizeof(FlutterOpenGLRendererConfig),
                .make_current = [](void* userdata) -> bool {
                  auto e = reinterpret_cast<Engine*>(userdata);

Above fix is probably only required for g++ & not clang++.

$ g++ --version
g++ (Ubuntu 11.2.0-7ubuntu2) 11.2.0

However when I attempt to run release bundle I see an error about missing flutter_assets/kernel_blob.bin

[INFO:display.cc(67)] No agl_shell extension present
[INFO:display.cc(71)] WL_SHM_FORMAT_XRGB32 not available
[INFO:display.cc(257)] Pointer Present
[INFO:display.cc(266)] Keyboard Present
[ERROR:/home/skamath/proactive/flutter/ivi-homescreen/shell/engine.cc(142)] (0) /usr/local/share/homescreen/bundle/flutter_assets/kernel_blob.bin missing Flutter Kernel

This patch series fixes some minor parsing isssues I've found while using the JSON config file.

Specifically, app_id specified over the configuration is being ignored and found similar issue with debug_backend and disable_cursor.

Allows making pixel_ratio something other than 1.0 using optional command line arg.

Examples --

./homescreen --w=640 --h=480 --r=2.0

./homescreen --w=640 --h=480 --r=0.5

Addressing issue described in #56 and simplifying the previous wayland mouse input events to flutter pointer events translation in ivi-homescreen:

Sanity checked implementation here against the official flutter linux shell's mouse input handling for motion, scrolling and button events. The relevant analogous code sections are linked below:

Motion: https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_view.cc#L371-L372 motion events are either kMove or KHover, matching linux desktop: https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_view.cc#L383

Scrolling (Axis in wayland): https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_scrolling_manager.cc#L67 Notice that for scrolling events the pointer phase is disregarded and kMove is chosen arbitrarily based on this comment https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_scrolling_manager.cc#L122-L123

Button: https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_view.cc#L114-L115 Currently this PR does not drop redundant events but perhaps it should try to mimic such behavior. Another difference is that this PR does not keep track of previous button state and so only sends kUp or kDown events for button events, never kMove or KHover, it's unclear to me if this should behavior should be copied or not. https://github.com/flutter/engine/blob/main/shell/platform/linux/fl_view.cc#L130-L148

Tested this PR manually on the default flutter increment button app which no longer crashes with debug assertions described in Issue #56.

On my ubuntu 20.04, wayland+weston+ivi-homescreen running the default flutter create "increment" button app with debug engine v2.10.3 arm64, I'm finding that the app often crashes when using mouse input because this assertion check fails.

[FATAL:flutter/lib/ui/window/pointer_data_packet_converter.cc(189)] Check failed: !state.is_down. 

https://github.com/flutter/engine/blob/main/lib/ui/window/pointer_data_packet_converter.cc#L190

I believe this is a manifestation of a bug in translating wayland input events to flutter, specifically within Display::pointer_handle_motion() https://github.com/toyota-connected/ivi-homescreen/blob/main/shell/display.cc#L399

Which calls getPointerPhase(), and in some instances the state can be such that p->buttons is not null and state == WL_POINTER_BUTTON_STATE_RELEASED which ends up translating the event to FlutterPointerPhase::kUp. https://github.com/toyota-connected/ivi-homescreen/blob/main/shell/display.cc#L337 However, if no kDown event is sent between this kUp event and some previous kUp event (say from releasing the mouse button) then the debug assert fails and the app crashes with the FATAL warning above.

Based on what I've gathered from reading the comments in embedder.h https://github.com/flutter/engine/blob/main/shell/platform/embedder/embedder.h#L727-L743

I propose that the wayland input event listener Display::pointer_handle_motion() should only translate to FlutterPointerPhase::kMove or FlutterPointerPhase::kHover depending on whether the left mouse button is currently pressed down or not during the motion event. PR that implements this change coming shortly.

From my understanding, ivi-homescreen can launch the flutter aseets placed at /usr/local/share/homescreen only. How can I launch multiple flutter apps with ivi-homescreen?

If ivi-homescreen accepts another flutter assets path from cmdline args like flutter-wayland(https://github.com/chinmaygarde/flutter_wayland), ivi-homescreen will become more flexible.

What do you think of this idea?

• Fixes: "The following _CastError was thrown while checking if the clipboard has strings: type 'bool' is not a subtype of type 'Map<String, dynamic>?' in type cast"

Signed-off-by: Joel Winarske [email protected]

Hi toyota-connected/ivi-homescreen!

This is not an automatic, 🤖-generated PR, as you can check in my GitHub profile, I work for GitHub and I am part of the GitHub Security Lab which is helping out with the migration of LGTM configurations to Code Scanning. You might have heard that we've integrated LGTM's underlying CodeQL analysis engine natively into GitHub. The result is GitHub code scanning!

With LGTM fully integrated into code scanning, we are focused on improving CodeQL within the native GitHub code scanning experience. In order to take advantage of current and future improvements to our analysis capabilities, we suggest you enable code scanning on your repository. Please take a look at our blog post for more information.

This pull request enables code scanning by adding an auto-generated codeql.yml workflow file for GitHub Actions to your repository — take a look! We tested it before opening this pull request, so all should be working :heavy_check_mark:. In fact, you might already have seen some alerts appear on this pull request!

Where needed and if possible, we’ve adjusted the configuration to the needs of your particular repository. But of course, you should feel free to tweak it further! Check this page for detailed documentation.

Questions? Check out the FAQ below!

FAQ

Only a single instance of Video Player is currently supported. The static plugin needs to be refactored to handle multiple views.

Currently a low priority.

@jwinarske I tried to run my app to check the ivi-homescreen's features related to input envents, but, my app have not worked correctly. It seems ivi-homescreen cannot accept any keyboard events at least.

The behavior of my app is the following.

• When the up half of the window is clicked, the mid bar will become blue to indicate that the up half takes focus.
• While the up half takes focus, TextField will start to work.
• When A or B key is pressed, some messages like [A_KeyDown][A_Repeat][A_KeyUp] will be output in the low half of the window.
• When other keys is pressed, a character of a pressed key is visible in TextField.

When I use the official linux-desktop device, the app worked correctly, but, when I use ivi-homescreen for Desktop, even if I press any keys, the app has no reaction for any keys.

Please see the video.

How can I use keyboard inputs in ivi-homescreen? OR, keyboard inputs is the missing feature of ivi-homescreen?

SIDE NOTES: ivi-homescreen causes core-dump when it is interrupted by Ctrl-C.

$ ~/homescreen --a=build/flutter_assets
[INFO:display.cc(50)] agl_shell extension not present
[INFO:display.cc(280)] Pointer Present
[INFO:display.cc(289)] Keyboard Present
[INFO:engine.cc(200)] Runtime=debug
[INFO:engine.cc(91)] flutter: The Dart VM service is listening on http://127.0.0.1:42187/ufLHlW6rddA=/
[INFO:navigation.cc(33)] Navigation: Select Single Entry History
[INFO:navigation.cc(47)] Navigation: Route Information Updated
	location: /
	state: 
	replace: 0
dddddddddddddddaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbb^C[FATAL:flutter/fml/thread_local.cc(30)] Check failed: false. pthread_setspecific failed (22): Invalid argument
[1]    28678 abort (core dumped)  ~/homescreen --a=build/flutter_assets