As discussed with Eddie a couple of weeks ago, the override names aren't being set in the class, but the UUID is.

If somebody can fix this soon it should be fairly easy. Right now the overrides will use UUID like 54334-343-3434334-34334_strvalue for the name which just bloats the code uncessarily.

New rules were already implemented, but there was some mistakes on how they were handle. Now new rules should be correctly represented also changed positioned & container to better match the rules

1. Created a simple sketch file trying to replicate how the demo sketch layer out it's components.
2. Opened the terminal to the the Parabeac-Core Directory, and entered the command to convert the Sketch file to flutter code.
3. Got the following messages on the terminal:

[INFO]: Installing Para-beac core and its dependencies

audited 525 packages in 4.62s

34 packages are looking for funding run npm fund for details

found 1 moderate severity vulnerability run npm audit fix to fix them, or npm audit for details

Installed Sketch Asset Converter dependencies

Error: Error when reading 'pub': No such file or directory npm WARN [email protected] No repository field. npm WARN [email protected] No license field.

[INFO]: No URL provided

[INFO]: Processing plugins...

[INFO]: Plugin already in file. Skipping...

[ERROR]: No semantics found for Tab

[INFO]: Plugin already in file. Skipping...

[INFO]: Plugin already in file. Skipping...

[INFO]: Done processing!

Main: [INFO] - [-p, /Users/saidajo/Desktop/magic_calculator.sketch, -n, MagicTest]

Sketch: [INFO] - We encountered a page that has 0 page items.

Sketch: [INFO] - We encountered a page that has 0 page items.

Interpret: [ERROR] - NoSuchMethodError: The getter 'boundaryRectangle' was called on null. Receiver: null Tried calling: boundaryRectangle

PBAlignGenerationService: [WARNING] - We don't support class type Null for adding to the queue.

lib/main.dart: Warning: Interpreting this as package URI, 'package:parabeac_core/main.dart'. Unhandled exception: NoSuchMethodError: The getter 'name' was called on null. Receiver: null Tried calling: name #0 Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5) #1 Interpret._generateGroup (package:parabeac_core/controllers/interpret.dart:85:31) #2 Interpret.interpretAndOptimize (package:parabeac_core/controllers/interpret.dart:64:49) #3 SketchController.convertSketchFile (package:parabeac_core/controllers/sketch_controller.dart:31:38) #4 main (package:parabeac_core/main.dart:86:30) #5 _RootZone.runUnary (dart:async/zone.dart:1450:54) #6 _FutureListener.handleValue (dart:async/future_impl.dart:143:18) #7 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45) #8 Future._propagateToListeners (dart:async/future_impl.dart:725:32) #9 Future._completeWithValue (dart:async/future_impl.dart:529:5) #10 Future._asyncCompleteWithValue. (dart:async/future_impl.dart:567:7) #11 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #12 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #13 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) #14 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

4. After Getting these messages I entered nom audit to get details from the first message saying that their was a nom vulnerability and got the following message:

npm ERR! code EAUDITNOPJSON npm ERR! audit No package.json found: Cannot audit a project without a package.json

This seems to be an issue relating to the post-layout rules. The attached photo shows a Stack with a background container & another container. It should've been reduced to a Background Container holding the Text Container. Another issue but unrelated is in the Login button. You can see that the alignment service did not inject a Positioned for the relationship between the Stack & its children which resulted in incorrect looking UI.

If you create a group inside Sketch with no children, Parabeac will except out and your main.dart file will become blank.

You can regenerate it, but you lose any changes you have added.

This has been discussed with the Parabeac team, but this would be a more natural approach to applying a naming semantic. It doesn't make or break anything but would be a better UX on the Sketch side.

A clear and concise description of what the bug is.

Just cloned the project and tried running

dart parabeac.dart -p /Users/faridgarciayala/Desktop/Parabeac-Core/test/assets/SymbolTest-simp.sketch  -n test

I got the following error:

Align Generator: [ERROR] - NoSuchMethodError: The method 'addImport' was called on null. Receiver: null Tried calling: addImport("package:auto_size_text/auto_size_text.dart")

Project Builder: [ERROR] - ProcessException: No such file or directory Command: flutter create /Users/faridgarciayala/Desktop/Parabeac-Core/test/assets/test

Provider: [INFO] - Thanks for trying our state management configuration that is now in Beta! If you run into any issues please feel free to post it in Github or in our Discord! Provider: [INFO] - Setting up the directories

Align Generator: [ERROR] - NoSuchMethodError: The method 'addImport' was called on null. Receiver: null Tried calling: addImport("package:auto_size_text/auto_size_text.dart")

lib/main.dart: Warning: Interpreting this as package URI, 'package:parabeac_core/main.dart'. Unhandled exception: FileSystemException: Cannot open file, path = '/Users/faridgarciayala/Desktop/Parabeac-Core/test/assets/test/pubspec.yaml' (OS Error: No such file or directory, errno = 2) #0 _File.throwIfError (dart:io/file_impl.dart:635:7) #1 _File.openSync (dart:io/file_impl.dart:479:5) #2 _File.readAsBytesSync (dart:io/file_impl.dart:539:18) #3 _File.readAsStringSync (dart:io/file_impl.dart:584:18) #4 _File.readAsLinesSync (dart:io/file_impl.dart:590:36) #5 PBFlutterWriter.submitDependencies (package:parabeac_core/generation/generators/writers/pb_flutter_writer.dart:71:38) #6 GenerationConfiguration._commitDependencies (package:parabeac_core/generation/generators/value_objects/generation_configuration/pb_generation_configuration.dart:155:14) #7 GenerationConfiguration.generateProject (package:parabeac_core/generation/generators/value_objects/generation_configuration/pb_generation_configuration.dart:122:11) #8 ProviderGenerationConfiguration.generateProject (package:parabeac_core/generation/generators/value_objects/generation_configuration/provider_generation_configuration.dart:30:17) #9 FlutterProjectBuilder.convertToFlutterProject (package:parabeac_core/generation/flutter_project_builder/flutter_project_builder.dart:127:35) #10 Controller.convertFile (package:parabeac_core/controllers/controller.dart:55:15) #11 SketchController.convertFile (package:parabeac_core/controllers/sketch_controller.dart:37:17) #12 main (package:parabeac_core/main.dart:166:24) #13 _RootZone.runUnary (dart:async/zone.dart:1450:54) #14 _FutureListener.handleValue (dart:async/future_impl.dart:143:18) #15 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45) #16 Future._propagateToListeners (dart:async/future_impl.dart:725:32) #17 Future._complete (dart:async/future_impl.dart:519:7) #18 _StreamIterator._onDone (dart:async/stream_impl.dart:1087:20) #19 _RootZone.runGuarded (dart:async/zone.dart:1372:10) #20 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:410:13) #21 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:420:15) #22 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:305:7) #23 _SinkTransformerStreamSubscription._close (dart:async/stream_transformers.dart:97:11) #24 _EventSinkWrapper.close (dart:async/stream_transformers.dart:23:11) #25 _StringAdapterSink.close (dart:convert/string_conversion.dart:251:11) #26 _Utf8ConversionSink.close (dart:convert/string_conversion.dart:305:20) #27 _ConverterStreamEventSink.close (dart:convert/chunked_conversion.dart:82:18) #28 _SinkTransformerStreamSubscription._handleDone (dart:async/stream_transformers.dart:142:24) #29 _RootZone.runGuarded (dart:async/zone.dart:1372:10) #30 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:410:13) #31 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:420:15) #32 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:305:7) #33 _SyncStreamControllerDispatch._sendDone (dart:async/stream_controller.dart:816:19) #34 _StreamController._closeUnchecked (dart:async/stream_controller.dart:671:7) #35 _StreamController.close (dart:async/stream_controller.dart:664:5) #36 _Socket._onData (dart:io-patch/socket_patch.dart:2051:21) #37 _RootZone.runUnaryGuarded (dart:async/zone.dart:1384:10) #38 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11) #39 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7) #40 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19) #41 _StreamController._add (dart:async/stream_controller.dart:682:7) #42 _StreamController.add (dart:async/stream_controller.dart:624:5) #43 new _RawSocket. (dart:io-patch/socket_patch.dart:1587:35) #44 _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1069:18) #45 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #46 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #47 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) #48 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

AB#755

Change Proposal

Use the .g.dart output for generated files and only generate .dart files if they don't exist. This should use darts way of importing or separating abstract/generated classes.

Module and Current Solution

Generation modules outputs .dart files which are really generated files.

Benefits of the Change

Allows the developer to overwrite those .g.dart files without fear of losing changes to .dart files.

Request Type: Code Refactor

Description

The method for interpret dart on Parabeac Core is currently very long and functions like a pipe filter, this proposal is to break that into separate methods based on responsibility.

Current Solution

The current structure is just a very long and difficult to read method that handles the entire process of generating screens within the Interpret.dart file

Proposed Solution

Instead of having all of the logic happen within this function in the interpret.dart file, have this function call other functions that handle the specific task being formed at that point. This would clean up the code and make it a lot easier to both read and maintain going forward.

Files Affected:

• interpret.dart

Additional Notes:

Currently in both parabeac.dart and main.dart the arguments are being parsed using a for-loop and a switch statement. This can lead to many errors when parsing arguments and can be quite inefficient.

In order to improve this we can use the args package which provides elegant argument-parsing functionality, reduces the potential for errors, and will make the code more concise.

Describe the bug

I tested parabeac on a simple mobile screen in Sketch. I'm really impressed with the conversion and very excited by your project. I'll continue with more complex screens. But, as it is, I think this is amazingly clean, even with the warnings issued by the "dart parabeac.dart" command output, below:

To Reproduce

Steps to reproduce the behavior:

1. Run the dart parabeac.dart -p command. It started with these errors.

$ dart parabeac.dart -p /Users/brianfogel/Sites/TestBed.sketch -n playground audited 537 packages in 1.876se and its dependencies

43 packages are looking for funding run npm fund for details

found 1 moderate severity vulnerability run npm audit fix to fix them, or npm audit for details [====] Installed Sketch Asset Converter dependencies npm WARN [email protected] No repository field. npm WARN [email protected] No license field.

/Users/brianfogel/Sites/parabeac-core/pb-scripts/install.sh: line 38: pub: command not found /Users/brianfogel/Sites/parabeac-core/pb-scripts/install.sh: line 42: 80977 Killed: 9 spin $* (wd: ~/Sites/parabeac-core)

The important part of the above output was moderate severity vulnerability. The suggested fix did not work:

$ npm audit fix npm ERR! code EAUDITNOPJSON npm ERR! audit No package.json found: Cannot audit a project without a package.json

npm ERR! A complete log of this run can be found in: npm ERR! /Users/brianfogel/.npm/_logs/2021-03-14T00_39_17_989Z-debug.log

Further into the command output was this warning:

warning: failed to load external entity "tempout.xml"

What is the "tempout.xml" file? Is it important or useful and what happens if it can't be loaded?

The command output finished with this warning:

lib/main.dart: Warning: Interpreting this as package URI, 'package:parabeac_core/main.dart'. Unhandled exception: ProcessException: No such file or directory Command: dartfmt -w /Users/brianfogel/Sites/playground/bin /Users/brianfogel/Sites/playground/lib /Users/brianfogel/Sites/playground/test #0 _ProcessImpl._runAndWait (dart:io-patch/process_patch.dart:476:7) #1 _runNonInteractiveProcessSync (dart:io-patch/process_patch.dart:619:18) #2 Process.runSync (dart:io-patch/process_patch.dart:66:12) #3 FlutterProjectBuilder.convertToFlutterProject (package:parabeac_core/generation/flutter_project_builder/flutter_project_builder.dart:153:15) #4 Controller.convertFile (package:parabeac_core/controllers/controller.dart:55:5) #5 SketchController.convertFile (package:parabeac_core/controllers/sketch_controller.dart:37:5)

The project's lib folder is /Users/brianfogel/Sites/playground/lib. What does this warning mean? Did this cut off the conversion process?

I opened the converted files in my IDE

Impact of the problem

I'm not sure what the impact of these warnings and error were but I'm providing them in case they're useful.

Environment:

• MacOS Big Sur 11.2
• fish shell 3.20
• nvm 0.37.2
• node v14.16.0
• IntelliJ Ultimate 2020.3
• Dart 2.12.0
• Flutter 2.0.1

Additional comments/context:

It would be nice if the documentation talked more about the proper way to locate the 'parabeac-core' folder in relation to an existing flutter project folder. What if I already have identically named folders and dart files? Would parabeac overwrite them?

I located the 'parabeac-core' repo folder one folder above an existing project directory ('playground') to see what it would do. It modified my project's main.dart file by replacing the body of void main() {}.

void main() {
  runApp(
    MultiProvider(
      providers: [],
      child: MyApp(),
    ),
  );
}

Previously it was:

void main() {
  runApp(HomePage());
}

That's not so bad in this case but it could have been much worse and the documentation should talk about this. It also created a new folder and file hierarchy under lib.

screens └page_1 └sign_in.dart

In hindsight it did that because 'Sign in' is under 'Page 1' in my Sketch file, but what if that folder and file hierarchy had already existed? Would parabeac have overwritten them?

I had to make very minor edits to the converted flutter and dart code. I'm running with null safety and luckily the auto_size_text package has a pre-release null safe version and provider is null safe. There were some spelling oddities that in hindsight I can see were due to how I named layers and elements in Sketch. I did not use <> annotation in the layer or element names to help with the conversion. For now I just wanted to see what would happen to a file conversion without me making any changes to it. Thank you for this project.

Hello,

I tried to download the source code of parabeac locally on MAC. Tried to generate a project using commands. It did create successfully with the Hello world Figma file that you have as an example.

But If I use a different Figma file which is a bigger project by itself in Figma. I am not able to create the project successfully,

The command used by. me is $ pub get $ dart parabeac.dart -f -k -o

This is failing to generate saying Error During Communication: Error occured while Communication with Server with StatusCode : 429

So, does Figma file creation should be in any format ?

Please advice.

Thanks in advance, Champa

Describe the bug

Figma has some interesting capabilities, one of them is being able to generate empty vectors. Parabeac-core takes all vectors & download them as svgs, but if the vector happen to be empty, Parabeac-core cannot download it. But the issue comes when it tries to still use & export that svg on the files, the pubspec.yaml for example, complains about missing assets. I believe, core should detect the empty svg, that was not exported & then let the rest of core know, to not use it, since it will not be exported.

To Reproduce

Steps to reproduce the behavior:

1. Convert Figma file https://www.figma.com/file/WyKbF0awxlRmAIJ9JP4YvR/FYTR-Parabeac-Build?node-id=843%3A1829
2. On the output, look for the svg asset, states.svg
3. It should not be there, but if we look on the pubspec.yaml we will see, that it is part of the package

Impact of the problem

In case of multiple empty vectors, it will generate a lot of not necessary lines.

Environment:

• OS: macOS

Describe the bug

A custom frame is created with its respective constraints, in this case the only child of the custom frame is an svg. Svg is created correctly but the parent constraints of the container are incorrect. As we can see on the attached screen shot. As we can see on the second screenshot, the frame with & height is set to 24, while on the output container it gets 12 & 7.41 for height & width. Which are the children's constraints.

To Reproduce

Steps to reproduce the behavior:

1. Using core, transform the Figma file https://www.figma.com/file/EleFMmkgmKJoS0IwwBZ3jc/FYTR-Parabeac-Build-(Copy)?node-id=849%3A3960
2. Once it is done, look for the component meal_cart_card.g.dart
3. Scroll down to line 142 & look for DecrementMealQuantityCustom
4. See error

Impact of the problem

It is an inaccurate output

Environment:

• OS: macOS

Screenshots

When leveraging assets that are being generated from Parabeac, you're often leveraging an SVG Object or Image which requires a String as the call. For example: "assets/home_icon".

I believe this could be reduced to something like ProjectAssets.home_icon which would return the SVG already prepared as a widget. This would reduce the amount of code that the developer would have to write when leveraging the assets.

Describe the bug

Global Styles in Figma have wide flexibility in the naming. As such, Figma allows me to name my global styles something like 012 My Style. This is a problem because parabeac_core will export this style name as a variable named 012myStyle.

The goal of this issue is to correctly format color names in such a way that we remove any invalid special characters, and move any initial numbers in the variable name to the end of the variable.

Therefore, 012my$Style shall convert to myStyle012. If we detect a global style with a name such as 500we shall change it to <styleType>500. For example, if we have a Global Color named 500, the name will change to color500.

To Reproduce the bug

Steps to reproduce the behavior:

1. Go to figma.com and create a new Design file.
2. Create a global color, named something like 012myColor.
3. Using parabeac_core, convert the file.
4. You should see that in the themes folder, there is an error because the global color printed out its literal name.

Impact of the problem

The problem is that the bug causes compiler errors that will not allow users to run their project.

Environment:

• OS: macOS