Addressing Issue #24. Successfully migrated the project to Null-Safety

Please let me know if I have to do further changes to get the Hacktoberfest Approval

Greetings there,

when the installation process was cancelled by the user the command prompt that was opened ( at 25% process ) is not closing. that must be checked once.

https://drive.google.com/file/d/1xtxsWsBOOyGz8xOTDrlcJwKCxiN4h9FL/view?usp=sharing

thanks in advance.

Running "flutter pub get" in flutter_installer...
Launching lib\main.dart on Windows in debug mode...                                                       lib\main.dart:1
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/get_navigation-3.12.0/lib/src/extension_navigation.dart(462,37): error GBF4691A2: No named parameter with the name 'shadowThemeOnly'. [C:\Users\minnu\Documents\Projects\Flutter\flutter_installer\build\windows\flutter\flutter_assemble.vcxproj]
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/get_navigation-3.12.0/lib/src/extension_navigation.dart(655,43): error GBF4691A2: No named parameter with the name 'shadowThemeOnly'. [C:\Users\minnu\Documents\Projects\Flutter\flutter_installer\build\windows\flutter\flutter_assemble.vcxproj]
Exception: Build process failed.
Exited (sigterm)

I don't know what was the issue exactly. I got this issue for Windows. This must need a fix ASAP, cause not even building the .exe file at all. IT'S FAILING TO BUILD. I even tried googling but I failed every time 😭 .

I will add the result of flutter run -v here out.log.

Refer this for more info. issue#69872

[ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Bad state: Cannot add event after closing
#0      _StreamController.add (dart:async/stream_controller.dart:623:24)
#1      _StreamSinkWrapper.add (dart:async/stream_controller.dart:900:13)
#2      run.<anonymous closure>
package:process_run/process_run.dart:228
#3      run.<anonymous closure>
package:process_run/process_run.dart:226
#4      _rootRunUnary (dart:async/zone.dart:1198:47)
#5      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#6      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#7      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#8      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#9      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19)
#10     _StreamController._add (dart:async/stream_controller.dart:682:7)
#11     _StreamController.add (dart:async/stream_controller.dart:624:5)
#12     _Socket._onData (dart:io-patch/socket_patch.dart:1969:41)
#13     _rootRunUnary (dart:async/zone.dart:1206:13)
#14     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#15     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#16     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#17     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#18     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19)
#19     _StreamController._add (dart:async/stream_controller.dart:682:7)
#20     _StreamController.add (dart:async/stream_controller.dart:624:5)
#21     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1505:33)
#22     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1017:14)
#23     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#24     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
flutter: 💡  InstallingViewModel - Finished Download of "flutter_linux_1.22.3-stable.tar.xz" from "https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_1.22.3-stable.tar.xz"
flutter: 💡  InstallingViewModel - Started Extracting of flutter_linux_1.22.3-stable.tar.xz from https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_1.22.3-stable.tar.xz
[ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Bad state: Cannot add event after closing
#0      _StreamController.add (dart:async/stream_controller.dart:623:24)
#1      _StreamSinkWrapper.add (dart:async/stream_controller.dart:900:13)
#2      streamSinkWrite
package:process_run/src/shell_utils.dart:254
#3      streamSinkWriteln
package:process_run/src/shell_utils.dart:250
#4      runCmd
package:process_run/cmd_run.dart:52
#5      Shell.runExecutableArguments
package:process_run/shell.dart:270
#6      Shell.run
package:process_run/shell.dart:245
#7      _upzipDownloadedFlutterSdkForLinux
package:flutter_installer/…/scripts/linux.dart:377
<asynchronous suspension>
#8      installOnLinux
package:flutter_installer/…/scripts/linux.dart:108
<asynchronous suspension>
#9      InstallingViewModel.install
package:flutter_installer/…/installing/installing_view_model.dart:152
<asynchronous suspension>
#10     InstallingViewModel.initialize
package:flutter_installer/…/installing/installing_view_model.dart:102
<asynchronous suspension>

Reproduuce the error

• Select everything you want and click next.
• click on install.
• cancel it and check in console log.

[ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Bad state: Cannot add event after closing
#0      _StreamController.add (dart:async/stream_controller.dart:623:24)
#1      _StreamSinkWrapper.add (dart:async/stream_controller.dart:900:13)
#2      streamSinkWrite
package:process_run/src/shell_utils.dart:254
#3      streamSinkWriteln
package:process_run/src/shell_utils.dart:250
#4      Shell.cd
package:process_run/shell.dart:200
#5      Shell.pushd
package:process_run/shell.dart:209
#6      _cdToTempDirectory
package:flutter_installer/…/scripts/linux.dart:240
<asynchronous suspension>
#7      installOnLinux
package:flutter_installer/…/scripts/linux.dart:58
<asynchronous suspension>
#8      InstallingViewModel.install
package:flutter_installer/…/installing/installing_view_model.dart:152
<asynchronous suspension>
#9      InstallingViewModel.initialize
package:flutter_installer/…/installing/installing_view_model.dart:102
<asynchronous suspension>

If you cancel it before the download starts.

Publishable packages can't have git dependencies. 
Try adding a 'publish_to: none' entry to mark the package as not for publishing or remove the git dependency.

It gives warning if we use git for the packages which are in pub.dev.

Reference Image

OS: Linux-distro (ParrotOS)

Flutter Channel: Master

┌─[minnu@parrot]─[~]
└──╼ $flutter --version
Flutter 1.24.0-7.0.pre.44 • channel master • https://github.com/flutter/flutter.git
Framework • revision 5511abd90f (12 hours ago) • 2020-11-01 16:13:03 +0530
Engine • revision 3460519398
Tools • Dart 2.12.0 (build 2.12.0-3.0.dev)

Fix

Adding

publish_to: 'none'

will fix this. As we are not publishing this Installer in pub.dev, we can add publish_to: 'none'.

Hello there again 😆,

I would like to suggest you to use git clone command in Process.run(). As I have seen the command in installation console you are using

curl -o flutter_windows_1.17.5-stable.zip https://storage.googleapis.com/flutter_infra/releases/stable/windows/flutter_windows_1.17.5-stable.zip

Here, it gonna take long time to download it and to extract it. so instead using clone will save the time ⏳️ and also space.

I'm working on it. and it is about to complete please do check once I request a pull.

Regards 💙

Debug Console

Restarted application in 825ms.
flutter: 🐛  SharedPrefsService - (TRACE) LocalStorageService:_getFromDisk. key: theme_mode_flutter_installer value: ThemeMode.dark
flutter: 💡  InstallingViewModel - Install On Linux
flutter: 💡  InstallingViewModel - Installation Cancelled!
flutter: 💡  InstallingViewModel - Archive Name: flutter_linux_1.22.3-stable.tar.xz
flutter: 💡  InstallingViewModel - Temp Directory Name: flutter_installer
flutter: 💡  InstallingViewModel - Created Shell: Instance of 'Shell'
flutter: 💡  InstallingViewModel - Change Directory to Temp
flutter: 💡  InstallingViewModel - Change directory to flutter_installer
flutter: 💡  InstallingViewModel - Distro Name: parrot
4.10

flutter: 💡  InstallingViewModel - Started Download of "flutter_linux_1.22.3-stable.tar.xz" from "https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_1.22.3-stable.tar.xz"

Procedure to reproduce

video for more refernce

This is a critical fix to do, add some critical tag :rofl:

Steps to reproduce:

1. Choose a path to install flutter.
2. Click next.
3. Come back and check the path.

Reference:

https://user-images.githubusercontent.com/35523357/102960979-3750da80-4509-11eb-90c1-9c0cdb6fe0ef.mp4

While installing, my installation is stuck in 53% with 'Downloading Script for adding Flutter to PATH', and the last LOG was 'flutter/version'. Does anyone have solution for this? Or it is normal?

Hi,

awesome project. I found that unfortunately it doesn't install all the needed files for Linux Desktop which would be really helpful. I tried to install them manually but somehow together with your installer it didn't work after that.

P.S: you should an an buymeacoffee to thie repo not only Patreon :-)

@YazeedAlKhalaf On the latest release v0.0.8, cancel button is not working. need a quick fix for that and also theme_box.hive and theme_box.lock are saving in the installation location. Hope you are aware of this.