Description

• Found that on the 'Add New Folder' click, the app is creating a folder 'sussy'.
• Have added an alert box with a text field to enter the folder name with a create button to create the folder with the name specified name in the text field, also added a cancel button to close the alert box.
• The alert box will give flexibility on the name of the folder as compared to the previous version where it was mostly static.
• No dependency is required.

Screenshots

Type of change

UI Change

Please tick the relevant option by putting an X inside the bracket

• [X] Bug fix (non-breaking change which fixes an issue)
• [X] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [X] My code follows the guidelines of this project
• [X] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [X] My changes generate no new warnings
• [ ] All current GitHub actions pass
• [X] Any dependent changes have been merged and published in downstream modules
• [X] I have checked my code and corrected any misspellings
• [X] I have read the CONTRIBUTING document

Signed-off-by: Ayush P Gupta [email protected]

Description

This PR upgrades isar dependency to latest so as to make it run on linux host.

Please note this is a breaking change in terms of isar and its db path.

Fixes #(issue)

#5

Screenshots (if appropriate):

Type of change

Please tick the relevant option by putting an X inside the bracket

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [x] My code follows the guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] All current GitHub actions pass
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I have checked my code and corrected any misspellings
• [x] I have read the CONTRIBUTING document

Description

Introducing a new way to display files in an application. Any display of a list of elements must be variable. It is more convenient for someone to view files in the form of a table, and for someone in the form of a grid. By clicking on IconButton inside BreadCrumbsBar u can switch view. I think design not very important if u already start working on redesign.

One of the important thing is sorting files. At this point in repo we use sorting by column indexes, in my opinion, it's a wrong way, we must use enum for this. Didn't bother touching this part because it goes out of the area of this PullRequest. And also i think we need to discuss it

Also fix missing files issue #13

Screenshots:

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

Checklist:

• [x] My code follows the guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] All current GitHub actions pass
• [ ] Any dependent changes have been merged and published in downstream modules
• [x] I have checked my code and corrected any misspellings
• [x] I have read the CONTRIBUTING document

Description

Develop an abstract class BaseContextMenuEntry from which you must to inherit to create a custom context menu element. Create base class ContextMenuEntry that allow you to customize elements using leading, title and shortcut properties. A context menu should be provided for almost any element of a graphical application, which is why it has been added to the SidePane and TabStrip widgets. A ContextSubMenuEntry was also created that provides the ability to call a submenu. Move all the elements dependent on the context menu to a separate directory

Screenshots:

Type of change

Please tick the relevant option by putting an X inside the bracket

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [x] My code follows the guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] All current GitHub actions pass
• [ ] Any dependent changes have been merged and published in downstream modules
• [x] I have checked my code and corrected any misspellings
• [x] I have read the CONTRIBUTING document

Description

• Added a "show hidden files" option inside a pop up menu to the side of the Add new folder button.

• This is usually seen in files applications

• No dependency required.

• Fixes #9

Screenshots (if appropriate):

Type of change

UI/Backend change

Please tick the relevant option by putting an X inside the bracket

• [X] Bug fix (non-breaking change which fixes an issue)
• [X] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [X] This change requires a documentation update

Checklist:

• [X] My code follows the guidelines of this project
• [X] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [X] My changes generate no new warnings
• [X] All current GitHub actions pass
• [ ] Any dependent changes have been merged and published in downstream modules
• [X] I have checked my code and corrected any misspellings
• [X] I have read the CONTRIBUTING document

Signed-off-by: Ayush P Gupta [email protected]

Description

This PR aims at improving linter taking ref from @dahliaOS/welcome repo

Fixes #(issue)

Screenshots (if appropriate):

Type of change

Please tick the relevant option by putting an X inside the bracket

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [x] My code follows the guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] All current GitHub actions pass
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I have checked my code and corrected any misspellings
• [x] I have read the CONTRIBUTING document

Describe the bug When u open folder with hidden files and turn off "Show hidden files" option u can't see some files

What kind of a bug is it? This is the application bug

To Reproduce Steps to reproduce the behavior:

1. Go to any folder with hidden files in it
2. Turn off "Show hidden files" option
3. See error

Expected behavior U must see all files

The problem is that you can not remove elements from the list using for loop. In this situation u lost one file after removing hidden from the list https://github.com/dahliaOS/files/blob/a613958e340c83228d1b961329036968890eee93/lib/backend/fetch.dart#L51-L62

One way to fix this is filtrate the list before loop:

    List<FileSystemEntity> newList = list
        .where(
          (element) =>
              !Utils.getEntityName(element.path).startsWith(".") || showHidden,
        )
        .toList();

Probably i can take that issue on myself after announcing new feature

Hello,

I have tested the files app and did not find a way to show/hide hidden files. Currently, all the hidden files are being shown in the application.

If you would like, the button for it could be on a kebab menu on the left/right side of the "add new folder" button

Currently the project depends on isar pre release version which thereby causes

flutter: Invalid argument(s): Failed to load dynamic library 'libisar.so': libisar.so: cannot open shared object file: No such file or directory

error when running on Linux host. I probably assume that we can solve this once we upgrade to v1.0+ but because it requires some breaking change hence we might need to be careful and see issues related to that

Description

• support Linux without XDG variables set
• perform update of package:platform

Fixes no issue

Screenshots (if appropriate):

• none

Type of change

Please tick the relevant option by putting an X inside the bracket

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [x] My code follows the guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] All current GitHub actions pass
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I have checked my code and corrected any misspellings
• [x] I have read the CONTRIBUTING document

Signed-off-by: TheOneWithTheBraid [email protected]

Hello,

I have tested this dahliaOS version and the Files app does not support creation time (crtime/btime) for local folders and files.

https://github.com/dahliaOS/releases/releases/tag/201215-x86_64

Here more information about file system timestamps: https://wiki.sleuthkit.org/index.php?title=Mactime_output