Describe the bug Without a comment on the same line the import 'package:flutter_gen/gen_l10n/translations.dart'; gets removed when running flutter pub run import_sorter:main.

To Reproduce You can just add the import to your main.dart file after creating a new project. It won't be able to build, but running flutter pub run import_sorter:main after saving the file still deletes the import. Note: even after there are no build errors it still deletes it

Expected behavior The import should not be deleted.

Meta Information:

• Dart Version: 2.10.2
• import_sorter Version: 4.2.2
• Is it a Flutter project? Yes
• What version of Flutter are you using (if flutter project): 1.22.2

Additional Context The import is sorted correctly if you add a comment to the same line. For example: import 'package:flutter_gen/gen_l10n/translations.dart'; // gets removed

import 'package:flutter_gen/gen_l10n/translations.dart'; // import_sorter:keep // gets sorted correctly

Hi, I would like to use this together with my git hook, and have my changed files sorted only. It would be great to having a way to sort only a subset of files, instead of sorting all of them.

Describe the bug Precommit hook doesn't sort imports

To Reproduce What command or actions did you take to produce this error? Followed the steps at https://pub.dev/packages/import_sorter When I run 'pre-commit run --all-files' nothing happens

.pre-commit-config.yaml:

repos:
    - repo: https://github.com/pre-commit/pre-commit-hooks
      rev: v3.4.0
      hooks:
          - id: trailing-whitespace
          - id: end-of-file-fixer
          - id: check-yaml
          - id: check-added-large-files
    - repo: https://github.com/fluttercommunity/import_sorter
      rev: "master"
      hooks:
          - id: flutter-import-sorter

I got it working with this hotfix as .pre-commit-config.yaml:

repos:
    - repo: https://github.com/pre-commit/pre-commit-hooks
      rev: v3.4.0
      hooks:
          - id: trailing-whitespace
          - id: end-of-file-fixer
          - id: check-yaml
          - id: check-added-large-files
    - repo: local
      hooks:
          - id: imputsorter
            name: imputsorter
            entry: flutter pub run import_sorter:main
            language: system
            files: ^lib/

It may have something to do with the 'files: .dart$'

Meta Information:

• Flutter Version: 1.24.0-10.2
• import_sorter Version: ^4.4.1

Hello everyone. I'm sad to say that today I am going to be archiving import_sorter. Unfortunately I no longer work with dart and flutter anymore and as I go into college I don't have a lot of free time to maintain the project. Anyone is free to fork the code or take over as maintainer but I am going to be archiving the project today. Sorry for any inconveniences this may cause and thank you so much for all the support.

Describe the bug After executing the flutter pub run import_sorter:main command I get following error:

username@PC044-MacOS flutter_my_app % flutter pub run import_sorter:main

┏━━🗂  Sorting 94 dart files
┃  ┃
┃  ┣━━ ✅ Sorted 0 out of 7 imports in lib/drawer/drawer_navigation.dart
┃  ┣━━ ✅ Sorted 0 out of 1 imports in lib/drawer/naviagtion_router.dart
Unhandled exception:
RangeError (index): Invalid value: Not in inclusive range 0..1: 2
#0      List.[] (dart:core-patch/growable_array.dart:177:60)
#1      main (file:///Users/username/development/flutter/.pub-cache/hosted/pub.dartlang.org/import_sorter-4.4.0/bin/main.dart:97:149)
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
pub finished with exit code 255

To Reproduce I installed the import_sorter package and did run flutter pub run import_sorter:main

Expected behavior correct sorting, but it stopped after two files.

Screenshots

Meta Information:

• Dart Version: 2.10.4
• import_sorter Version: 4.4.0
• Is it a Flutter project? Yes
• What version of Flutter are you using (if flutter project): 1.22.4

Describe the bug In my CI, I use (or at least, I would love to use, because this very issue prevents me from doing so) dart format -l 100 --output none --set-exit-if-changed . to format my code. After that, I want to check if my imports are sorted using flutter pub run import_sorter:main --exit-if-changed. Now, it is just not possible for those two actions to complete successfully (they're mutually exclusive), and that is because import_sorter removes trailing newlines from files without any import ... statements (or at least it looks like so).

File 1 Example file that causes problems (i.e trailing newline is removed by import_sorter):

enum HomeEvent { showInfo, showDiscover, showProfile }

File 2 Example file that works fine (i.e trailing newline is not removed by import_sorter):

import 'dart:core';

enum HomeEvent { showInfo, showDiscover, showProfile }

To Reproduce

1. Create a file with contents of file 1
2. dart format -l 100 .
3. The file will have 2 lines: 1 line of code and a trailing newline. That's what I want.
4. flutter pub run import_sorter:main --no-comments
5. Check file contents. There won't be a trailing newline at the end of the file. I don't want this.
6. dart format -l 100 .. A trailing newline will be there again. Yay!

Expected behavior import_sorter should not delete the trailing newline.

Useful resources

• How to easily check if a file has a trailing newline
• according to my experience (I'm on macOS), the easiest way to edit a file is using TextEdit.app (it does not insert a trailing newline automatically, while several other programs I've used do insert a trailing newline (e.g nano)). To open a file in with TextEdit, use open -e <file>

Meta Information:

• Dart Version: 2.12.3
• import_sorter Version: 4.5.0
• Is it a Flutter project? Yes
• What version of Flutter are you using (if flutter project): 2.0.6

Is your feature request related to a problem? Please describe. It is not clear what files were changed from the import_sorter output. In fact. all files appear to be changed. I would like to review files that were changed by the tool. This could be especially useful when running import_sorter as a pre-commit hook.

Describe the solution you'd like I would like to see just an "Ok" for files that were not changed and the current output for those that were.

Describe alternatives you've considered There is none.

I just ran the importer and it broke the project.

Reviewing the file that was reported by the analyzer as broken and comparing to GitHub I saw that library XXXXXX; had been stripped.

Thanks for this package! I've got a little suggestion.

I like the idea to sort my imports, but I would like to have the comments removed. A flag to sort the imports without adding comments like "Flutter imports:" would be great.

Is your feature request related to a problem? Please describe. When I run code generation, the sorting and comments for imports are overridden and they aren't very relevant for generated code anyway.

Describe the solution you'd like The option to provide a regular expression like **/*.g.dart that skips files matching it.

Describe the bug When flutter pub run import_sorter:main is run, it exits with exit code 127, and fails to run flutter pub get. However, when flutter pub get is run individually of flutter pub run import_sorter:main, it works fine, and running flutter pub get -v produces the expected output, all exit codes 0.

To Reproduce I ran flutter pub run import_sorter:main. I am using import_sorter 3.0.5, Ubuntu 19.10, Flutter 1.8.0-11.1.pre on channel beta, and Dart 2.9.0-8.2.beta.

Expected behavior I expected the program to run properly, or at the very least, not fail on flutter pub get, but rather another step.

Screenshots

Meta Information:

• Dart Version:
• import_sorter Version: ^3.0.5
• Is it a Flutter project? Yes.
• What version of Flutter are you using (if flutter project): 1.8.0-11.1.pre on channel beta

Is your feature request related to a problem? Please describe. We are migrating our projects to a single monorepo and would love to have only one configuration set for all the stuff related to import sorting. Now, as ignoring files are only supported to be specified in the pubspec.yaml file we have to replicate that config per project instead of just once at the root of the monorepo.

Describe the solution you'd like We would love to specify the config of import_sorter in a YAML file which could be passed using a relative path to the sort command.

Describe alternatives you've considered I've tried to build a negative REGEX and pass it to the command (e.g. sort all imports here except those ending in *.g.dart), but without success. If such a regex is possible, no config file would be needed as all the config options could be passed in one global command.

You can add extra key in pubspec:

import_sorter:
  header: 'Extra header above' # Optional, adds extra line above all imports.

Result:

// Extra header above!

// 🎯 Dart imports:
import 'dart:io';

.....

Closes #59

• Add conversion of project imports to relative imports for lib files.
• Add test for convertToRelativeImports

Question: The example app has the following import but no corresponding dependency import 'package:flutter_gen/gen_l10n/translations.dart';

Is your feature request related to a problem? Please describe. The current execution of flutter pub run import_sorter:main has a slow start due to the Dart VM initialisation. While it is acceptable if it is ran infrequently (like as a GIT commit hook for example), it is a lot more critical when running frequently (like every time a file is saved for example).

Describe the solution you'd like

• Give users guidelines to use the natively compiled version of the library rather that its Dart version
• OR find a way to distribute the compiled versions

Describe alternatives you've considered I have tested the execution time of this library for three different versions:

• 1: The Dart version, as described in the README
• 2: The AOT compiled version, as described in https://dart.dev/tools/dart-compile#aot-snapshot
• 3: The executable compiled version, as described in https://dart.dev/tools/dart-compile#exe

Results:

• 1 was the slowest, with an initialisation time of about 1 to 2 seconds on a i9 2019 Macbook Pro 16'.
• 2 was faster, maybe twice faster.
• 3 was the fastest, almost instantaneous

Additional context The benefits of running a compiled version are also explained in https://dart.dev/tutorials/server/get-started#6-compile-for-production.

This is what I've done to get a nice experience using this lib:

1. Compile to native code

dart compile exe bin/main.dart -o bin/import_sorter

2. Add bin path to PATH
3. Use lib in VSCode with https://marketplace.visualstudio.com/items?itemName=emeraldwalk.RunOnSave I've set it up with the following settings:

  "emeraldwalk.runonsave": {
    "commands": [
      {
        "match": "\\.dart$",
        "cmd": "import_sorter ${file}"
      }
    ]
  }

Now every time I save a file in my IDE, the imports are organised instantaneously! This makes it a lot more enjoyable.

It would be great if this package can change our absolute imports to relative imports.

Example 1 import 'package:my_app/lib/src/foo.dart' to import 'foo.dart'

Example 2

import 'package:my_app/lib/src/p1/foo.dart'
import 'package:my_app/lib/src/p2/foo.dart'

to

import 'p1/foo.dart'
import 'p2/foo.dart'

if imported in src to

import '../p1/foo.dart'
import 'foo.dart'

if imported in p2

I would like to contribute to this feature but can anyone guide me with this?