Hi Anna,
Thanks for the great workshop! I found it very easy and fluent to complete the whole workshop, and the difficulty increases gradually, which is awesome! I've also learned more about the MaterialState*
that used to exist without some proper explanations.
Estimate total time to take the workshop: 40 minutes
Though I still have some questions and concerns, some of them are addressed in the PR, I'll tell others in the below description.
Linter rules ignore
I saw all dart files are marked with multiple linter rules ignored, as I found they're unnecessary to ignore, I've removed most of them and filled codes with a proper format. Please let me know if you have some other opinion about it.
Confusion in instructions
In fact, under the hood, the MaterialApp
widget passes the given theme value to the inner Theme
widget, which wraps all application screens.
Given the fact of the source code, I don't think it actually wraps all application screens, but wraps at the top of the application. I've update the sentence in the change.
Customize global iconTheme
. The email and globe icons should become lime and half-transparent. The account icon in the top corner should become half-transparent.
I got a bit confused here since the account icon has its own requirement without Colors.lime
, but I saw it still has a different color from other icons, which should be inherited from the AppBarTheme
. I'm wondering if such inherit relation needs to tell users.
However, describing all TextStyle
fields of TextTheme
is unnecessary.
It might be typically unnecessary, just a nit.
and is not showing an error;
There are multiple short sentences with the same suffix here, which might be redundant.