@dnfield in https://discord.com/channels/608014603317936148/1039667632342835250/1039710167329165342

Remark: I will mark a lot of my comments below as resolved, since they are solely used as external memory of my brain instead of real discussions with people interested in this thread. (Originally thought only me in this thread so do so)

Is your feature request related to a problem? Please describe. $./flutter/tools/gn --unoptimized --no-goma --no-prebuilt-dart-sdk $ ninja -C out/host_debug_unopt

in engine/src/out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/window.dart 265 line is still as void render(Scene scene) => _render(scene);

Describe the solution you'd like how do i compile engine/lib/ui/window.dart into dart sdk? i search google for long time, but no one explain engine compile with dart sdk

Required by https://github.com/flutter/engine/pull/36911

As dnfield points out, I should:

• [ ] we need some motivating benchmarks that clearly show what benefits would be gained here -> this issue
• [x] and we need to see that changes to this won't negatively impact existing benchmarks/users -> later (since I do not have access to run skia perf?)

code should be at https://github.com/fzyzcjy/engine/tree/feat/await-vsync-directly-call

Please refer to

1. The doc https://cjycode.com/flutter_smooth/
2. ~~The project board https://github.com/users/fzyzcjy/projects/5~~ Just refer to issue section since some things are in issue but not in project: https://github.com/fzyzcjy/flutter_smooth/issues

Describe the bug i have tried to run smooth example app but i have got these errors

`../smooth/lib/src/infra/extra_event_dispatcher.dart:48:9: Error: No named parameter with the name 'filter'. filter: (entry) { ^^^^^^ ../smooth/lib/src/infra/extra_event_dispatcher.dart:114:24: Error: The method 'readEnginePendingEventsAndClear' isn't defined for the class 'GestureBinding'.

• 'GestureBinding' is from 'package:flutter/src/gestures/binding.dart' ('/F:/flutter/packages/flutter/lib/src/gestures/binding.dart'). Try correcting the name to the name of an existing method, or defining a method named 'readEnginePendingEventsAndClear'. gestureBinding.readEnginePendingEventsAndClear(); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:130:17: Error: Type 'HitTestEntryFilter' not found. {required HitTestEntryFilter? filter}) { ^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:301:7: Error: Class 'WidgetsFlutterBinding with SmoothSchedulerBindingMixin, SmoothGestureBindingMixin with SmoothRendererBindingMixin' inherits multiple members named 'GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%SmoothGestureBindingMixin.dispatchEvent' with incompatible signatures. Try adding a declaration of 'GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%SmoothGestureBindingMixin.dispatchEvent' to 'WidgetsFlutterBinding with SmoothSchedulerBindingMixin, SmoothGestureBindingMixin with SmoothRendererBindingMixin'. class SmoothWidgetsFlutterBinding extends WidgetsFlutterBinding ^ /F:/flutter/packages/flutter/lib/src/gestures/binding.dart:415:8: Context: This is one of the overridden members. void dispatchEvent(PointerEvent event, HitTestResult? hitTestResult) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... /F:/flutter/packages/flutter/lib/src/rendering/binding.dart:328:8: Context: This is one of the overridden members. void dispatchEvent(PointerEvent event, HitTestResult? hitTestResult) { ^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:301:7: Error: Class 'WidgetsFlutterBinding with SmoothSchedulerBindingMixin, SmoothGestureBindingMixin, SmoothRendererBindingMixin with SmoothWidgetsBindingMixin' inherits multiple members named 'GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%SmoothGestureBindingMixin.dispatchEvent%RendererBinding.dispatchEvent' with incompatible signatures. Try adding a declaration of 'GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%GestureBinding.dispatchEvent%RendererBinding.dispatchEvent%SmoothGestureBindingMixin.dispatchEvent%RendererBinding.dispatchEvent' to 'WidgetsFlutterBinding with SmoothSchedulerBindingMixin, SmoothGestureBindingMixin, SmoothRendererBindingMixin with SmoothWidgetsBindingMixin'. class SmoothWidgetsFlutterBinding extends WidgetsFlutterBinding ^ /F:/flutter/packages/flutter/lib/src/gestures/binding.dart:415:8: Context: This is one of the overridden members. void dispatchEvent(PointerEvent event, HitTestResult? hitTestResult) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... /F:/flutter/packages/flutter/lib/src/gestures/binding.dart:415:8: Context: This is one of the overridden members. void dispatchEvent(PointerEvent event, HitTestResult? hitTestResult) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:60:9: Error: The method 'adjustForEpoch' isn't defined for the class 'SmoothSchedulerBindingMixin'.
• 'SmoothSchedulerBindingMixin' is from 'package:smooth/src/infra/binding.dart' ('../smooth/lib/src/infra/binding.dart'). Try correcting the name to the name of an existing method, or defining a method named 'adjustForEpoch'. adjustForEpoch(rawTimeStamp ?? currentSystemFrameTimeStamp)); ^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:130:17: Error: 'HitTestEntryFilter' isn't a type. {required HitTestEntryFilter? filter}) { ^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:140:49: Error: No named parameter with the name 'filter'. super.dispatchEvent(event, hitTestResult, filter: filter); ^^^^^^ ../smooth/lib/src/infra/binding.dart:169:9: Error: No named parameter with the name 'fallbackVsyncTargetTime'. fallbackVsyncTargetTime: effectiveFallbackVsyncTargetTime, ^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/binding.dart:217:11: Error: No named parameter with the name 'forceDirectlyCallNextVsyncTargetTime'. forceDirectlyCallNextVsyncTargetTime: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/proxy.dart:13:53: Error: The getter 'nodesNeedingPaint' isn't defined for the class 'PipelineOwner'.
• 'PipelineOwner' is from 'package:flutter/src/rendering/object.dart' ('/F:/flutter/packages/flutter/lib/src/rendering/object.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'nodesNeedingPaint'. List get nodesNeedingPaint => inner.nodesNeedingPaint; ^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/proxy.dart:141:27: Error: No named parameter with the name 'fallbackVsyncTargetTime'. inner.render(scene, fallbackVsyncTargetTime: fallbackVsyncTargetTime); ^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/proxy.dart:259:11: Error: No named parameter with the name 'forceDirectlyCallNextVsyncTargetTime'. forceDirectlyCallNextVsyncTargetTime: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/auxiliary_tree_pack.dart:36:27: Error: Method not found: 'TickerRegistry'. final _tickerRegistry = TickerRegistry(); ^^^^^^^^^^^^^^ ../smooth/lib/src/infra/auxiliary_tree_pack.dart:58:14: Error: The method 'TickerRegistryInheritedWidget' isn't defined for the class 'AuxiliaryTreePack'.
• 'AuxiliaryTreePack' is from 'package:smooth/src/infra/auxiliary_tree_pack.dart' ('../smooth/lib/src/infra/auxiliary_tree_pack.dart'). Try correcting the name to the name of an existing method, or defining a method named 'TickerRegistryInheritedWidget'. child: TickerRegistryInheritedWidget( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/auxiliary_tree_pack.dart:181:26: Error: Unexpected type 'invalid-type' of a spread. Expected 'dynamic' or an Iterable. ..._tickerRegistry.tickers, ^ ../smooth/lib/src/infra/auxiliary_tree_pack.dart:225:16: Error: Setter not found: 'debugActiveLayout'. RenderObject.debugActiveLayout = null; ^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/auxiliary_tree_pack.dart:229:18: Error: Setter not found: 'debugActiveLayout'. RenderObject.debugActiveLayout = oldDebugActiveLayout; ^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/actor.dart:135:9: Error: No named parameter with the name 'fallbackVsyncTargetTime'. fallbackVsyncTargetTime: ^^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/infra/actor.dart:143:34: Error: The method 'notifyIdle' isn't defined for the class 'PlatformDispatcher'.
• 'PlatformDispatcher' is from 'dart:ui'. Try correcting the name to the name of an existing method, or defining a method named 'notifyIdle'. binding.platformDispatcher.notifyIdle( ^^^^^^^^^^ ../smooth/lib/src/drop_in/page_route/page_routes.dart:77:3: Error: The superclass, 'PageRouteBuilder with SmoothPageRouteMixin', has no unnamed constructor that takes no arguments. SmoothPageRouteBuilder({ ^^^^^^^^^^^^^^^^^^^^^^ ../smooth/lib/src/drop_in/page_route/page_routes.dart:104:11: Error: No named parameter with the name 'allowSnapshotting'. allowSnapshotting: false, ^^^^^^^^^^^^^^^^^ ../smooth/lib/src/drop_in/list_view/controller.dart:71:25: Error: The getter 'controller' isn't defined for the class '_SmoothBallisticScrollActivity'.
• '_SmoothBallisticScrollActivity' is from 'package:smooth/src/drop_in/list_view/controller.dart' ('../smooth/lib/src/drop_in/list_view/controller.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'controller'. ?.controller.lastElapsedDuration?.inMicroseconds ?? ^^^^^^^^^^ ../smooth/lib/src/drop_in/list_view/controller.dart:140:3: Error: The superclass, 'BallisticScrollActivity', has no unnamed constructor that takes no arguments. _SmoothBallisticScrollActivity.raw( ^^^ ../smooth/lib/src/drop_in/list_view/shift.dart:352:36: Error: The getter 'startTime' isn't defined for the class 'Ticker'.
• 'Ticker' is from 'package:flutter/src/scheduler/ticker.dart' ('/F:/flutter/packages/flutter/lib/src/scheduler/ticker.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'startTime'. final tickTimeStamp = _ticker!.startTime! + selfTickerElapsed; ^^^^^^^^^ ../smooth/lib/src/drop_in/list_view/shift.dart:356:59: Error: The getter 'startTime' isn't defined for the class 'Ticker'.
• 'Ticker' is from 'package:flutter/src/scheduler/ticker.dart' ('/F:/flutter/packages/flutter/lib/src/scheduler/ticker.dart'). Try correcting the name to the name of an existing getter, or defining a getter or field named 'startTime'. final ballisticTickerStartTime = info.ballisticTicker.startTime; ^^^^^^^^^ ../smooth/lib/src/drop_in/list_view/list_view.dart:34:28: Error: The argument type 'Widget? Function(BuildContext, int)' can't be assigned to the parameter type 'Widget Function(BuildContext, int)' because 'Widget?' is nullable and 'Widget' isn't.
• 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('/F:/flutter/packages/flutter/lib/src/widgets/framework.dart').
• 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('/F:/flutter/packages/flutter/lib/src/widgets/framework.dart'). itemBuilder: itemBuilder, ^ ../smooth/lib/src/drop_in/list_view/list_view.dart:116:22: Error: A value of type 'Widget?' can't be returned from a function with return type 'Widget' because 'Widget?' is nullable and 'Widget' isn't.
• 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('/F:/flutter/packages/flutter/lib/src/widgets/framework.dart'). return widget.itemBuilder(context, index - 1);`

To Reproduce Steps to reproduce the behavior:

1. open example project
2. Click on run
3. click on run tab
4. See error

• https://github.com/flutter/engine/pull/36837
• https://github.com/flutter/engine/pull/37340

next steps

• [x] correct timing
• [x] fix compile error
• [x] do not use real sleep
• [x] extract "rasterizer sleep strategy" to a separate class
• [x] add tests to strategy
• [ ] pass tests of strategy

Question: how to do correct timing?

https://github.com/fzyzcjy/flutter_smooth/issues/165

Possible outline

• preemptRender
• Brake
• gesture subsystem
• how SmoothListView is implemented (also serve as an example to use SmoothBuilder)
• how SmoothMaterialPageRoute is implemented

Otherwise all these are so dispersed, and is hard to search...

• [x] the main github issue
• [x] several other github issues
• [x] design doc (google doc)
• [x] google doc comments (a lot)
• [x] discord channel
• [x] that one discord "threads" called "Preempt Render"
• [x] the several github PRs, also with discussions there

what to copy

• [x] the text
• [ ] the images (cannot be links - external links can die)
• [x] the timestamp (otherwise cannot see relationship between messages)
• [x] the author (who said it)
• [x] time of retrivial (updates can happen later)
• [x] link to the original content

How to download each of them?

github issue, github pr

e.g. gh issue view 38 --json author,body,comments

images in it

maybe write a small script

google doc content

maybe just copy-and-paste

images in it

maybe done manually

google doc comments

https://stackoverflow.com/questions/66103464/export-google-docs-comments-into-google-sheets-along-with-highlighted-text

discord

https://github.com/Tyrrrz/DiscordChatExporter

Bumps loader-utils from 2.0.3 to 2.0.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

1

• https://github.com/flutter/engine/pull/36916

This is not the only thing that would need peeking,a nd creating this kind of "pull" based model is a major architectural change we'd need more time to reason about. I'm going to close this PR to get it off of review queues for now - tests are not passing and it is not clear that this API is the desirable one to expose to developers to achieve the larger goals you're discussing.

2

• https://github.com/flutter/engine/pull/36607

I'm going to close this to remove it from review queues. As I'm mentioning in some other PRs, let's discuss further on discord.

https://github.com/flutter/engine/pull/36797

We don't want to expose this kind of internal of the VM to users. Perhaps it would be more appropriate to expose a different API around whether an animation is occurring currently, although I think @iskakaushik has already done some work on that.

https://github.com/flutter/engine/pull/36834

Same problems as the other NotifyIdle PR - these are details we don't want to expose to users. NotifyIdle might not do anything, or it might do a lot more than the user expects. In all honesty, it would be nice to get rid of it entirely since it is hard to reason about and seems to come out wrong very frequently. If users can change this arbitrarily it will make it much harder to reason about what's going on in an application. Closing this to remove from review queues. There is definitely work to do around NotifyIdle, but I think we'll need some cooperation from the dart VM team on it.